Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ysql: give NOTICE when creating index in txn block #9550

Closed
jaki opened this issue Jul 31, 2021 · 0 comments
Closed

ysql: give NOTICE when creating index in txn block #9550

jaki opened this issue Jul 31, 2021 · 0 comments
Assignees
@jaki
Labels
area/ysql Yugabyte SQL (YSQL) kind/improve-ux Issues relating to improving user experience.
Projects
Index backfill

Comments

@jaki
Copy link
Contributor

jaki commented Jul 31, 2021

CREATE INDEX in transaction block is not concurrent (does not use online schema change). This may not be expected behavior, so give a NOTICE for this. Other statements that don't use concurrent, like CREATE TABLE ... UNIQUE, don't really matter whether they are concurrent or not, so they shouldn't get the NOTICE.
@jaki jaki added kind/improve-ux Issues relating to improving user experience. area/ysql Yugabyte SQL (YSQL) 2.4 Backport Required labels Jul 31, 2021
@jaki jaki self-assigned this Jul 31, 2021
@jaki jaki added this to To do/Current-Sprint in Index backfill via automation Jul 31, 2021
@jaki jaki mentioned this issue Jul 31, 2021
Closed
@jaki jaki closed this as completed in 3e5edfa Aug 3, 2021
Index backfill automation moved this from To do/Current-Sprint to Done Aug 3, 2021
jaki added a commit that referenced this issue Aug 5, 2021
@jaki
[BACKPORT 2.4][#9550] ysql: output NOTICE when CREATE INDEX in txn block
eb59b23 
Summary:
There exists a DEBUG1 error message that indicates that the index is not
built concurrently when it is created in a transaction block.  To
increase visibility of this message, change it to NOTICE.  Also, reword
it better.

Original Commit: 3e5edfa

Original Differential Revision: https://phabricator.dev.yugabyte.com/D12447

Test Plan:
Jenkins: build platform: centos, compiler: clang, build type: debug, rebase: 2.4

    ./yb_build.sh --java-test TestPgRegressTable
    ./yb_build.sh --java-test TestPgRegressTypesUDT

Reviewers: mihnea

Reviewed By: mihnea

Subscribers: yql

Differential Revision: https://phabricator.dev.yugabyte.com/D12476
jaki added a commit that referenced this issue Aug 5, 2021
@jaki
[BACKPORT 2.6][#9550] ysql: output NOTICE when CREATE INDEX in txn block
5db0733 
Summary:
There exists a DEBUG1 error message that indicates that the index is not
built concurrently when it is created in a transaction block.  To
increase visibility of this message, change it to NOTICE.  Also, reword
it better.

Original Commit: 3e5edfa

Original Differential Revision: https://phabricator.dev.yugabyte.com/D12447

Test Plan:
Jenkins: build platform: centos, compiler: clang, build type: debug, rebase: 2.6

    ./yb_build.sh --java-test TestPgRegressTable
    ./yb_build.sh --java-test TestPgRegressTypesUDT

Reviewers: mihnea

Reviewed By: mihnea

Subscribers: yql

Differential Revision: https://phabricator.dev.yugabyte.com/D12475
radekg pushed a commit to radekg/yugabyte-db that referenced this issue Aug 12, 2021
@jaki @radekg
[yugabyte#9550] ysql: output NOTICE when CREATE INDEX in txn block
3dac712 
Summary:
There exists a DEBUG1 error message that indicates that the index is not
built concurrently when it is created in a transaction block.  To
increase visibility of this message, change it to NOTICE.  Also, reword
it better.

Close: yugabyte#9550

Test Plan:
Jenkins: build platform: centos, compiler: clang, build type: debug

    ./yb_build.sh --java-test TestPgRegressTable
    ./yb_build.sh --java-test TestPgRegressTypesUDT

Reviewers: mihnea

Reviewed By: mihnea

Subscribers: yql

Differential Revision: https://phabricator.dev.yugabyte.com/D12447
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jaki jaki

Labels
area/ysql Yugabyte SQL (YSQL) kind/improve-ux Issues relating to improving user experience.
Projects
Index backfill
  
Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jaki