Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] document minTimeUUID & maxTimeUUID in YCQL #12351

Merged
merged 2 commits into from
May 29, 2022

Conversation

ddorian
Copy link
Contributor

@ddorian ddorian commented May 4, 2022

fixes #804

@ddorian ddorian added the area/documentation Documentation needed label May 4, 2022
@netlify
Copy link

netlify bot commented May 4, 2022

Deploy Preview for infallible-bardeen-164bc9 ready!

Name Link
🔨 Latest commit 79201d3
🔍 Latest deploy log https://app.netlify.com/sites/infallible-bardeen-164bc9/deploys/6272c61a519f9700087e4ad4
😎 Deploy Preview https://deploy-preview-12351--infallible-bardeen-164bc9.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Contributor

@lizayugabyte lizayugabyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments

@@ -117,6 +117,98 @@ ycqlsh:example> SELECT todate(ts) FROM test_todate;
2018-10-09
```

## minTimeUUID(<timestamp>)

This function generates corresponding (`TIMEUUID`) with minimum node/clock component so that it includes all regular
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it a node or clock or both?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was taken from #801 (comment). I believe node/clock is correct?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lizayugabyte please recheck

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ddorian In tech docs, it needs to be either one or the other or both. The use of slash (1) creates ambiguity and (2) accessibility readers can't interpret slash between two words.


## maxTimeUUID(<timestamp>)

This function generates corresponding (`TIMEUUID`) with maximum node/clock component so that it includes all regular
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The same question about node/clock

+ fix a query that was using the wrong table
@ddorian ddorian requested a review from lizayugabyte May 4, 2022 18:31
@ddorian
Copy link
Contributor Author

ddorian commented May 27, 2022

@lizayugabyte please recheck

@ddorian ddorian merged commit e4c7e45 into yugabyte:master May 29, 2022
@ddorian ddorian deleted the doc-MinTimeUUID branch May 29, 2022 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/documentation Documentation needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[docs] YCQL: add minTimeUUID and maxTimeUUID functions to docs
2 participants