Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Added docs for vertx pg client for Java #13567

Merged
merged 12 commits into from
Aug 19, 2022

Conversation

priyanshi-yb
Copy link
Contributor

This PR adds the docs for Vertx PG Client in build-app for Java and mentions as supported client drivers in reference.

@CLAassistant
Copy link

CLAassistant commented Aug 10, 2022

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ priyanshi-yb
❌ Priyanshi Gupta


Priyanshi Gupta seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@netlify
Copy link

netlify bot commented Aug 10, 2022

Deploy Preview for infallible-bardeen-164bc9 ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 7bb14c7
🔍 Latest deploy log https://app.netlify.com/sites/infallible-bardeen-164bc9/deploys/62fdff523536ac0009ae9cc4
😎 Deploy Preview https://deploy-preview-13567--infallible-bardeen-164bc9.netlify.app/preview/develop/build-apps/java/ysql-vertx-pg-client
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@vkulichenko
Copy link
Contributor

@priyanshi-yb Should we add these changes to other versions as well, in addition to preview?

@priyanshi-yb
Copy link
Contributor Author

@vkulichenko We generally add the docs in the preview version only. I guess @polarweasel can tell us better about the other versions for the docs to be added.

@polarweasel polarweasel added the area/documentation Documentation needed label Aug 12, 2022
@polarweasel
Copy link
Contributor

I would say the build-apps stuff at least needs only to be in /preview. The changes in the driver file, though, should be in every version to which they're applicable.

@polarweasel polarweasel added this to In progress in Documentation via automation Aug 12, 2022
Copy link
Collaborator

@aishwarya24 aishwarya24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@priyanshi-yb , Added some comments. Will add more(if any) after testing the example.

priyanshi-yb and others added 8 commits August 16, 2022 01:28
…ent.md

Co-authored-by: Aishwarya Chakravarthy  <achakravarthy@yugabyte.com>
…ent.md

Co-authored-by: Aishwarya Chakravarthy  <achakravarthy@yugabyte.com>
…ent.md

Co-authored-by: Aishwarya Chakravarthy  <achakravarthy@yugabyte.com>
…ent.md

Co-authored-by: Aishwarya Chakravarthy  <achakravarthy@yugabyte.com>
…ent.md

Co-authored-by: Aishwarya Chakravarthy  <achakravarthy@yugabyte.com>
…ent.md

Co-authored-by: Aishwarya Chakravarthy  <achakravarthy@yugabyte.com>
Co-authored-by: Aishwarya Chakravarthy  <achakravarthy@yugabyte.com>
@priyanshi-yb priyanshi-yb merged commit f6ba4f7 into yugabyte:master Aug 19, 2022
Documentation automation moved this from In progress to Done Aug 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/documentation Documentation needed
Projects
Development

Successfully merging this pull request may close these issues.

None yet

6 participants