-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Added docs for vertx pg client for Java #13567
[docs] Added docs for vertx pg client for Java #13567
Conversation
Priyanshi Gupta seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
✅ Deploy Preview for infallible-bardeen-164bc9 ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
@priyanshi-yb Should we add these changes to other versions as well, in addition to preview? |
@vkulichenko We generally add the docs in the preview version only. I guess @polarweasel can tell us better about the other versions for the docs to be added. |
I would say the build-apps stuff at least needs only to be in /preview. The changes in the driver file, though, should be in every version to which they're applicable. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@priyanshi-yb , Added some comments. Will add more(if any) after testing the example.
docs/content/preview/develop/build-apps/java/ysql-vertx-pg-client.md
Outdated
Show resolved
Hide resolved
docs/content/preview/develop/build-apps/java/ysql-vertx-pg-client.md
Outdated
Show resolved
Hide resolved
docs/content/preview/develop/build-apps/java/ysql-vertx-pg-client.md
Outdated
Show resolved
Hide resolved
docs/content/preview/develop/build-apps/java/ysql-vertx-pg-client.md
Outdated
Show resolved
Hide resolved
docs/content/preview/develop/build-apps/java/ysql-vertx-pg-client.md
Outdated
Show resolved
Hide resolved
docs/content/preview/develop/build-apps/java/ysql-vertx-pg-client.md
Outdated
Show resolved
Hide resolved
docs/content/preview/develop/build-apps/java/ysql-vertx-pg-client.md
Outdated
Show resolved
Hide resolved
docs/content/preview/develop/build-apps/java/ysql-vertx-pg-client.md
Outdated
Show resolved
Hide resolved
…ent.md Co-authored-by: Aishwarya Chakravarthy <achakravarthy@yugabyte.com>
…ent.md Co-authored-by: Aishwarya Chakravarthy <achakravarthy@yugabyte.com>
…ent.md Co-authored-by: Aishwarya Chakravarthy <achakravarthy@yugabyte.com>
…ent.md Co-authored-by: Aishwarya Chakravarthy <achakravarthy@yugabyte.com>
…ent.md Co-authored-by: Aishwarya Chakravarthy <achakravarthy@yugabyte.com>
…ent.md Co-authored-by: Aishwarya Chakravarthy <achakravarthy@yugabyte.com>
Co-authored-by: Aishwarya Chakravarthy <achakravarthy@yugabyte.com>
This PR adds the docs for Vertx PG Client in build-app for Java and mentions as supported client drivers in reference.