[docs][YSQL] CREATE AGGREGATE, DROP AGGREGATE #2329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
September 16, 2019 06:15
Do all the steps of setting up a docs page for `CREATE AGGREGATE`. Don't worry about defining all rules and leave semantics and examples for later.
Add semantics for the `CREATE AGGREGATE` docs page by linking to the Postgres docs page. In contrast, add some detailed examples.
Bring back the `aggregate_signature` rule because it would be used in more than one place: `COMMENT` and `DROP AGGREGATE`.
Do all the steps of creating a docs page for `DROP AGGREGATE`. Move the `aggregate_signature` rule to the `DROP AGGREGATE` section out of the `Supporting rules` section. Update the `comment_on` rule to use the `aggregate_signature` rule. Do not add examples for `DROP AGGREGATE`, yet.
Add full set of examples for the `DROP AGGREGATE` docs page.
Fix things unrelated to `CREATE AGGREGATE` or `DROP AGGREGATE`: * Move `COMMENT` and `DO` rule sections in their respective alphabetically ordered positions * Fix links for the `DO` command in the `_index.md` files * Change the `::=` to `=` for the `do` rule.
|
Can one of the admins verify this patch? |
ndeodhar
reviewed
Sep 16, 2019
docs/content/latest/api/ysql/syntax_resources/ysql_grammar.ebnf
Outdated
Show resolved
Hide resolved
docs/content/latest/api/ysql/syntax_resources/ysql_grammar.ebnf
Outdated
Show resolved
Hide resolved
docs/content/latest/api/ysql/syntax_resources/ysql_grammar.ebnf
Outdated
Show resolved
Hide resolved
docs/content/latest/api/ysql/syntax_resources/ysql_grammar.ebnf
Outdated
Show resolved
Hide resolved
docs/content/latest/api/ysql/syntax_resources/ysql_grammar.ebnf
Outdated
Show resolved
Hide resolved
Address all of @ndeodhar's review comments: * Fix summary in `CREATE AGGREGATE` docs page * Fix some grammar rules that use curly braces when they should be parentheses
m-iancu
approved these changes
Sep 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes issue #2227.