RHGをリンクにする #2
Merged
RHGをリンクにする #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yui-knk
reviewed
Jun 10, 2023
README.md
Outdated
| @@ -21,7 +21,7 @@ Rubyで書かれたLALR(1) パーサジェネレーター [Racc](https://github. | |||
| ## TODO | |||
|
|
|||
| * 参考文献や参考になるサイトをまとめる | |||
| * RHG | |||
| * [『Ruby ソースコード完全解説 Ruby Hacking Guide』(RHG)](https://i.loveruby.net/ja/rhg/book/) | |||
There was a problem hiding this comment.
書籍のタイトルを確認したところ、"Rubyソースコード完全解説" とスペースがない表記のようなので以下のような書き方でどうでしょうか？
* [『Rubyソースコード完全解説』](https://i.loveruby.net/ja/rhg/book/)
There was a problem hiding this comment.
お返事おそくなりました。
書籍のタイトルを確認したところ、"Rubyソースコード完全解説" とスペースがない表記のようなので以下のような書き方でどうでしょうか？
はい。スペースがない表記の方が良いと思います！
There was a problem hiding this comment.
ありがとうございます。ではPRを修正していただけますでしょうか？
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
こちらの参考文献の項目は編集中だと思いますが、暫定的な段階でもリンクになっていると便利だと思います。チュートリアルを一緒に読み進めた方が、"RHG"が何の略か分からないということもありました。いかがでしょうか。