Fix issue with Router trying to URL-decode undefined path segments
#964
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * No changes. | ||
| ### Router | ||
|
|
||
| * Fixed issue with trying to URL-decode matching path segments that are |
There was a problem hiding this comment.
This could be a little more clear. I don't really understand what the change is from this.
There was a problem hiding this comment.
Added more info as you suggested.
|
👍, but I think the history entry needs to explain the problem more clearly. It should communicate what the problem was, why it was a problem, and what the fixed behavior is. |
|
This is ready go, when the tree is unfrozen. |
This was referenced Jul 16, 2013
ghost
assigned
|
Merging this… |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When Router is dispatching to a route's callbacks, it URL-decodes the matching path segments so that placeholders like
req.foodon't have encoded values. Since Router supports registering a route as a Regex, when Router executes that regex it may return an array with some undefined matches. This fixes the issue where Router assumed all items in the array returned fromexec()are strings.TODOs