Regex fix to avoid matching a trailing slash. #1677
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default regex
'([^/#?]*)'
inserted as a placeholder for matching named patterns matches empty components, such as a trailing slash. This means that a pattern such as/foo/:bar/:baz
will match/foo/BAR/
, while it should only matchfoo/BAR/BAZ
.Changing the regex to
'([^/#?]+)'
to require at least one character in the component keeps trailing slashes from matching the specified path.