Gesturesim4 #215
Merged
Gesturesim4 #215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 7, 2012 13:04
…d devices. Sugar gestures, doubletap and press gesture tests are added as well.
| GestureSimulation Change History | ||
| ========================== | ||
|
|
||
| 3.6.0 |
There was a problem hiding this comment.
This should be in either 3.6.1 or 3.7.0?
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Line coverages:
Desktop/Chrome - 60.29% (covers mouse blocks)
Desktop/IE - 60.29% (covers IE specific and mouse blocks)
Android - 79.04% (covers android/touch blocks)
iOS - 80.51% (covers ios/touch/Apple specific gesture blocks)
Since each platform has its own code path in the gesture-simulate, all combined should be much larger than the required 80% coverage.
Btw, this coverage covers only gesture-simulate module. Some other codes are also in event-simulate and node modules. I don't know how all coverages can be added up using yui-coverage tool. The node module has 1 line and about 300 lines in event-simulate module. Since added functions in event-module are low-level and used by all functions in gesture-simulate, the coverage should be very high.