Fix ScrollViewPaginator#scrollToIndex not taking anim duration/easing #274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ScrollViewPaginator#scrollToIndex takes an animation duration and easing
that aren't having any effect. This is because paginator.set('index',
index) triggers another call to scrollToIndex. This patch fixes that
behavior by passing an "src" option to paginator.set('index', index).
I added tests that check the time spent in the animation (with a margin
of error)
Shorter durations are usually very imprecise
ghost
assigned 
|
Thanks. Quick inspection looks good. I merged this into a local branch and will begin using it with dev work. Will update when it is pushed into Master or 3.x. |
|
Merged into 3.x, which means it will be included in the next release (3.8.0pr1). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In ScrollViewPaginator
scrollToIndextakes an animation duration and easing that aren't having any effect. This is becausepaginator.set('index', index)triggers another call toscrollToIndex. This patch fixes that behavior by passing an "src" option topaginator.set('index', index, {src: UI}).I added tests that check the time spent in the animation (with a margin of error)