Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow a small amount of touchMove before cancelling tap event. #631

Closed
wants to merge 1 commit into from

Conversation

riley-indochino
Copy link

This improves the user experience on touch screens by avoiding unintended cancelled clicks.

@tilomitra
Copy link
Contributor

Thanks for this pull! However, by removing the code that detaches the event handlers in the touchMove handler, we will be left with handlers that are not detached if the abs(startXY - endXY) > 15.

With this code change, these handlers should be removed in the touchEnd callback in an else case.

This test also causes a test failure (on purpose), due to the change to the touchMove handler. Could you add a test case to this code change to address this change, and remove the current test: touchmove test?

@ghost ghost assigned tilomitra Apr 18, 2013
@riley-indochino
Copy link
Author

I added the code to detach the event handlers in an else block in the touchEnd callback, but when I run the test event-tap-unit-tests.html with the changes, or without the changes they all pass. Is there a reason why these would pass when they shouldn't be?

@tilomitra
Copy link
Contributor

I bundled this fix into this pull request: #986

@tilomitra
Copy link
Contributor

This is done, since we merged #986.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants