Invalid transition and keyframes fix #312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't replace 0s and 0ms anymore the transitions will be considered invalid if for example the delay doesn't have an unit We don't replace 0% on the start of the line as it is needed to be a valid keyframe We replace the '100%' keyframe step for a 'to' which is 2 char shorter
This was referenced Aug 6, 2018
|
Someone merge this please. This is a long standing bug which is patched thanks to @Tofandel |
|
This is a huge bug... please merge! |
seyfahni
added a commit
to seyfahni/yuicompressor
that referenced
this pull request
Jun 26, 2019
seyfahni
added a commit
to seyfahni/yuicompressor
that referenced
this pull request
Jun 26, 2019
|
I think the regex needs to be... p = Pattern.compile("(?i)(^|,|\\{) ?(?:100% ?\\{)"); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't replace 0s and 0ms anymore the transitions will be considered invalid if for example the delay doesn't have an unit
We don't replace 0% on the start of the line as it is needed to be a valid keyframe
We replace the '100%' keyframe step for a 'to' which is 2 char shorter