Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FYI #12

Closed
xyproto opened this issue Mar 11, 2015 · 2 comments
Closed

FYI #12

xyproto opened this issue Mar 11, 2015 · 2 comments

Comments

@xyproto
Copy link

xyproto commented Mar 11, 2015

Thanks for writing gopher-lua, I'm using in it algernon and it works great!

Best regards,
Alexander F Rødseth

@yuin
Copy link
Owner

yuin commented Mar 11, 2015

Thank you for informing me.

I was noticing from the algernon source codes that an LState object is created for each http requests. To reduce LState creation costs, it may be better to use The LState pool pattern, I think.

@xyproto
Copy link
Author

xyproto commented Mar 11, 2015

Thanks! I implemented the suggested changes and everything works perfectly fine. It's hard to tell how much the performance improvement is (I'm sure it is there!), but it feels good to do it the proper way.

@xyproto xyproto closed this as completed Mar 11, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants