Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not use unsafe to take address of slice element #259

Merged
merged 1 commit into from
Dec 13, 2019

Conversation

zikaeroh
Copy link
Contributor

@zikaeroh zikaeroh commented Dec 7, 2019

Fixes #254.

Changes proposed in this pull request:

Note that this still doesn't make this repo pass in -race mode (which should really be looked into).

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.8%) to 89.071% when pulling 1d698ba on zikaeroh:fix-254 into c6266f4 on yuin:master.

@coveralls
Copy link

coveralls commented Dec 7, 2019

Coverage Status

Coverage decreased (-1.07%) to 88.757% when pulling 1d698ba on zikaeroh:fix-254 into c6266f4 on yuin:master.

@tul
Copy link
Contributor

tul commented Dec 9, 2019

I tested this change and it still allocates the floats correctly from the block as far as I can see, so this looks good to me +1

@epikur-io
Copy link

epikur-io commented Dec 13, 2019

I also tested this. Works great and makes the code much cleaner

@yuin yuin merged commit dc0d1ca into yuin:master Dec 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

runtime error: unsafe pointer arithmetic (Go 1.14 checkptr)
5 participants