Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lua table length is wrong when set element nil #261

Merged
merged 2 commits into from
Dec 13, 2019
Merged

lua table length is wrong when set element nil #261

merged 2 commits into from
Dec 13, 2019

Conversation

mzxdream
Copy link
Contributor

Fixes #260

Changes proposed in this pull request:

  • table.go

@coveralls
Copy link

coveralls commented Dec 11, 2019 •
edited

Coverage Status

Coverage increased (+0.2%) to 90.032% when pulling 1f6fab2 on mzxdream:master into c6266f4 on yuin:master.

@mzxdream mzxdream changed the title lua table length is wrong when set element nil #260 lua table length is wrong when set element nil Dec 11, 2019
@epikur-io
Copy link

This really should get merged.

@yuin
Copy link
Owner

yuin commented Dec 13, 2019

@mzxdream Could you add tests?

@yuin yuin merged commit f46add6 into yuin:master Dec 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

lua table length is wrong when set element nil
4 participants
@mzxdream @coveralls @epikur-io @yuin