Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

msvs generator may emit lf instead of crlf in headers for some python versions #10

Open
GoogleCodeExporter opened this issue Apr 19, 2015 · 4 comments

Comments

@GoogleCodeExporter
Copy link

The msvs generator uses the built-in xml module. This module accepts an eol 
parameter which can 
be used to specify an alternate line ending. This is used for the msvs 
generator since visual studio 
and incredibuild expect crlf. Unfortunately some versions of python2.4 
(including unfortunately the 
one chromium has checked in) ignore this parameter when emitting the xml 
header. Fortunately, 
visual studio and incredibuild will accept either variant for the header. But 
it would be nice to be 
consistent. We should find an alternative that works on all python versions.

Original issue reported on code.google.com by bradnel...@google.com on 27 Apr 2009 at 7:34

@GoogleCodeExporter
Copy link
Author

Should be simple to fix, but not actually hurting anyone.  (The IDEs accept the 
inconsistent line ending on the first line, but it looks ugly...)

Original comment by sgk@chromium.org on 6 Aug 2009 at 5:33

@GoogleCodeExporter
Copy link
Author

Original comment by sgk@chromium.org on 6 Aug 2009 at 5:33

@GoogleCodeExporter
Copy link
Author

Original comment by sgk@chromium.org on 18 Aug 2009 at 8:10

  • Added labels: MSVS

@GoogleCodeExporter
Copy link
Author

In Node we're also hitting this. Doesn't hurt but people are complaining of 
ugly XMLs.

Original comment by coldredl...@gmail.com on 16 Aug 2011 at 5:14

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant