CI against Ruby 2.2.8/2.3.5/2.4.2/JRuby 9.1.13.0 #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 similar comment
As of RuboCop v0.50.0, the Style/Encoding cop is now enabled by default and configured to remove the encoding magic-comment. Details here: rubocop/rubocop#4445
Gemspec/OrderedDependencies is enabled from 0.51.0 rubocop/rubocop#4874
3 similar comments
|
Sorry I didn't notice the existence of this PR and did most of the changes by myself. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes the following changes
Remove unnecessary Style/Encoding
As of RuboCop v0.50.0, the Style/Encoding cop is now enabled by default
and configured to remove the encoding magic-comment.
Details here: Enable Style/Encoding by default rubocop#4445
rubocop --auto-correct --only Gemspec/OrderedDependencies
Gemspec/OrderedDependencies is enabled from 0.51.0
Add new
Gemspec/OrderedDependenciescop rubocop#4874