Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config.raise_errors_for_deprecations! interferes w/ transpec #80

Closed
tjmcewan opened this issue Jul 15, 2014 · 2 comments
Closed

config.raise_errors_for_deprecations! interferes w/ transpec #80

tjmcewan opened this issue Jul 15, 2014 · 2 comments

Comments

@tjmcewan
Copy link

I was following the upgrade guide and added in: config.raise_errors_for_deprecations!. It wasn't immediately obvious, but an exception mid-way through the process causes transpec to drop back to static analysis. Perhaps add a note that this configuration is not ideal for running transpec?

Thanks!

transpec version 2.3.3

@yujinakayama
Copy link
Owner

Right. Thanks for the suggestion.

Perhaps add a note that this configuration is not ideal for running transpec?

Yeah. Also I think it would be better if Transpec can detect whether config.raise_errors_for_deprecations! is enabled and abort processing with a warning message if so.

@tjmcewan
Copy link
Author

Thanks very much! I have 12 more applications to update, so I very much appreciate the enhancement. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants