Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pickle serializer/deserializer implementation. #284

Merged
merged 3 commits into from Nov 27, 2022

Conversation

DoeringChristian
Copy link
Contributor

I have copied the yaml serializer and deserializer implementation and adapted it to work with pickle.
I'm not quite sure if this will find uses but I think it is nice to have direct serialization/deserialisation to pickle.
Added from_pickle and to_pickle methods to the tests.

@codecov
Copy link

codecov bot commented Nov 26, 2022

Codecov Report

Base: 90.74% // Head: 90.84% // Increases project coverage by +0.10% 🎉

Coverage data is based on head (1a0f7e9) compared to base (3f3de51).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #284      +/-   ##
==========================================
+ Coverage   90.74%   90.84%   +0.10%     
==========================================
  Files          10       11       +1     
  Lines        1599     1617      +18     
  Branches      342      342              
==========================================
+ Hits         1451     1469      +18     
  Misses        105      105              
  Partials       43       43              
Impacted Files Coverage Δ
serde/pickle.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Owner

@yukinarit yukinarit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thank you!

@yukinarit yukinarit merged commit 701348f into yukinarit:master Nov 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants