Allow bytes in from_json typing #471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #471 +/- ##
=======================================
Coverage 89.82% 89.82%
=======================================
Files 12 12
Lines 1937 1937
Branches 401 401
=======================================
Hits 1740 1740
Misses 145 145
Partials 52 52 ☔ View full report in Codecov by Sentry. |
yukinarit
reviewed
Feb 11, 2024
serde/de.py
Outdated
| @@ -390,7 +391,7 @@ class Deserializer(Generic[T], metaclass=abc.ABCMeta): | |||
|
|
|||
| @classmethod | |||
| @abc.abstractmethod | |||
| def deserialize(cls, data: T, **opts: Any) -> Any: | |||
| def deserialize(cls, data: AnyStr, **opts: Any) -> Any: | |||
There was a problem hiding this comment.
Can you leave it unchanged as it may be non AnyStr in the future?
There was a problem hiding this comment.
Good point. Done (amended)!
davetapley
force-pushed
the
from_json-bytes
branch
from
15880f0
to
919c1ab
Compare
davetapley
force-pushed
the
from_json-bytes
branch
from
919c1ab
to
e493deb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #450