Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't implement beartype for dataclass without serde #487

Merged
merged 1 commit into from
Mar 10, 2024

Conversation

yukinarit
Copy link
Owner

Closes #480

Copy link

codecov bot commented Mar 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.31%. Comparing base (43dca1d) to head (11a052f).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #487   +/-   ##
=======================================
  Coverage   90.31%   90.31%           
=======================================
  Files          12       12           
  Lines        1931     1931           
  Branches      400      400           
=======================================
  Hits         1744     1744           
  Misses        132      132           
  Partials       55       55           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yukinarit
Copy link
Owner Author

Hi @nicoddemus
Please take a look if this resolve your issue, thanks!

@nicoddemus
Copy link
Contributor

It does, thanks a lot for working on this @yukinarit!

Also, thanks for all the work you put into this library, it is excellent and a joy to use. 👍 🙇

@yukinarit yukinarit added the breaking-change Change without backward compatibility label Mar 10, 2024
@yukinarit yukinarit merged commit 7a30f56 into main Mar 10, 2024
9 checks passed
@yukinarit yukinarit deleted the fix-type-check-strict branch March 10, 2024 09:13
github-actions bot pushed a commit that referenced this pull request Mar 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change Change without backward compatibility
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bear type checking "leaks" to classes without the @serde decorator
2 participants