Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add some examples #511

Merged
merged 8 commits into from
Apr 22, 2024
Merged

add some examples #511

merged 8 commits into from
Apr 22, 2024

Conversation

JWSong
Copy link
Contributor

@JWSong JWSong commented Apr 8, 2024

Added examples for the types below:

  • UUID
  • pathlib
  • numpy
  • ipaddress

resolves #361 , #363 , #360 , #362

@JWSong
Copy link
Contributor Author

JWSong commented Apr 10, 2024

This PR and the test failure don't seem to be related. Can you check? @yukinarit

Copy link

codecov bot commented Apr 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.42%. Comparing base (4c54979) to head (fb93ed7).
Report is 41 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #511      +/-   ##
==========================================
+ Coverage   90.31%   91.42%   +1.10%     
==========================================
  Files          12       12              
  Lines        1931     1901      -30     
  Branches      400      401       +1     
==========================================
- Hits         1744     1738       -6     
+ Misses        132      107      -25     
- Partials       55       56       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Owner

@yukinarit yukinarit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @JWSong!

Thank you! Please update runner.py to make sure examples are tested in CI.

Modify beartype version due to a bug in Beartype 0.18.3
@JWSong
Copy link
Contributor Author

JWSong commented Apr 18, 2024

Hi @JWSong!

Thank you! Please update runner.py to make sure examples are tested in CI.

Done in af77ede!

The latest version of beartype has a bug breaking the tests, so I have updated its version.

There is a bug in the beartype version 0.18.3 that causes an error in the app, so I am updating the version to 0.18.4.
Copy link
Owner

@yukinarit yukinarit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@yukinarit yukinarit added the example Change in examples label Apr 22, 2024
@yukinarit yukinarit merged commit f0d38e6 into yukinarit:main Apr 22, 2024
8 checks passed
This was referenced Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
example Change in examples
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add UUID example
2 participants