Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A question about cost_mat in metric #22

Closed
Aguin opened this issue Jul 4, 2022 · 2 comments
Closed

A question about cost_mat in metric #22

Aguin opened this issue Jul 4, 2022 · 2 comments

Comments

@Aguin
Copy link

Aguin commented Jul 4, 2022

Hi @yuliangguo ,
I think the implementation here https://github.com/yuliangguo/Pytorch_Generalized_3D_Lane_Detection/blob/master/tools/eval_3D_lane.py#L165 is not exactly consistent with the formula in the paper.
2022-07-04 12-50-53 的屏幕截图
Besides, I also want to know why not use num_match_mat or something like match_ratio as the cost_mat.

@yuliangguo
Copy link
Owner

Hey, thanks for the questions. I am trying hard to recall the details. Hopefully the following answers your questions.

  1. I think you are right, there might be a typo in the paper. The middle case might not exist. The reported result should respect the code.
  2. There are some technical issues via using this MinCostFlow tool. First, it seems to only accept integer types. Second, the optimizer sometimes fails when using num_match_mat.

Ideally, the best solver should be the BSDS's bipartite matching for boundary matching, https://www2.eecs.berkeley.edu/Research/Projects/CS/vision/bsds/. However, it is old code implemented in matlab. I chose to implement MinCostFlow as a modern alternative way in python, but it has some limitations in the flexibility.

@yuliangguo
Copy link
Owner

yuliangguo commented Oct 11, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants