-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
quality aliases #34
Comments
You want to use chords like below. >>> Chord("Cmaj9")
<Chord: Cmaj9>
>>> Chord("Cmaj9") == Chord("CM9")
True You can define new qualities in |
i have more cases. i put them below. the thing is that there will always be more or different conventions (e.g. your 11th drops the third, but other use 6 notes). so i guess the best approach would be: a. get some statistics for the common qualities and use some official reference to decode them (i have some statistics from this project i can share: https://github.com/eyaler/uku3le). b. allow user to easily add/change aliases without need to modify the pycharm code. thanks for doing a great job! add2 -> (0, 2, 4, 7) |
I'm working with IRealBook data set they have lot more qualities, I have added degrees to them, maybe you want to merge them later, or discuss the jazz harmony rules on them.
|
Add qualities and support quality alias comparison #34
Thank you for introducing the qualities. I think tension chords like |
This idea is great. |
in QUALITY_DICT It seems to be conflicting with '/' means 'on Base'. ('69', (0, 4, 7, 9, 14)) and I need 'm69'. |
I recently wrote a script to sanity check some guitar chords I found online. These are the chord recipes whose interval I had to manually define:
As I am new to music theory, there might be some mistakes in there, but how would I go about translating them into the integer values required by the QualityManager? At the moment I am using the Interval class from the Musthe project to generate the set of chords from the string. |
@personalnadir For example, |
some common notation that is missing:
Xsus = X5
Xmaj7 = XM7
Xmaj9 = XM9
Xm6 = (0, 3, 7, 9)
Xmadd9 = (0, 3, 7, 14)
also is there a general way to add quality for aliases?
The text was updated successfully, but these errors were encountered: