feat: support for Git hosting other than GitHub #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
novr
force-pushed
the
feature/git_hosting
branch
from
aa701f3
to
593706a
Compare
el-hoshino
approved these changes
Jan 14, 2024
| public var customGitHubInstance: Danger.GitHub { | ||
| gitHubInstanceResolver() | ||
| public var customGitHostingInstance: GitHostingInstance? { | ||
| gitHostingInstanceResolver() |
There was a problem hiding this comment.
[imo]
publicなAPIはこれだけですので、一旦これを保留して、@available(*, deprecated) にして DangerDSL().github を返せばいいと思います 🙋
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
git hostingでgithub以外をサポートしました
etc
danger-swift local時にdanger.githubがnilでクラッシュしていたケースに対応fix