feat(github_repository): Show SnackBar if paging fails.

yumemi-inc · Apr 11, 2024 · 9ebc87e · 9ebc87e
1 parent a00d21e
commit 9ebc87e
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 6 deletions.
diff --git a/packages/cores/core/lib/src/ui/util/common_paging_view.dart b/packages/cores/core/lib/src/ui/util/common_paging_view.dart
@@ -1,5 +1,7 @@
+import 'package:cores_core/exception.dart';
 import 'package:cores_core/src/pagination/model/paging_data.dart';
 import 'package:cores_core/src/pagination/provider/paging_async_notifier.dart';
+import 'package:cores_core/util.dart';
 import 'package:flutter/material.dart';
 import 'package:flutter_riverpod/flutter_riverpod.dart';
 
@@ -23,7 +25,7 @@ class CommonPagingView<
   const CommonPagingView({
     required AutoDisposeAsyncNotifierProvider<N, D> provider,
     required Widget Function(D, Widget?) contentBuilder,
-    required VoidCallback? onError,
+    required void Function(AppException e) onError,
     super.key,
   })  : _contentBuilder = contentBuilder,
         _provider = provider,
@@ -37,15 +39,21 @@ class CommonPagingView<
   /// displayed at the end of the list if it's non-null.
   final Widget Function(D data, Widget? endItem) _contentBuilder;
 
-  final VoidCallback? _onError;
+  final void Function(AppException e) _onError;
 
   @override
   Widget build(BuildContext context, WidgetRef ref) {
     ref.listen(
       _provider,
       (_, next) {
         if (!next.isLoading && next.hasError) {
-          _onError?.call();
+          final error = next.error;
+          if (error is AppException) {
+            _onError(error);
+            return;
+          }
+          // AppException is expected, so this should never be reached.
+          logger.shout('Error: $error');
         }
       },
     );

diff --git a/packages/features/github_repository/lib/src/ui/github_repository_list.dart b/packages/features/github_repository/lib/src/ui/github_repository_list.dart
@@ -1,3 +1,4 @@
+import 'package:cores_core/exception.dart';
 import 'package:cores_core/ui.dart';
 import 'package:cores_designsystem/components.dart';
 import 'package:cores_navigation/providers.dart';
@@ -52,9 +53,7 @@ class GitHubRepositoryList extends HookConsumerWidget {
           );
         },
       ),
-      onError: () {
-        // TODO: Implement error handling.
-      },
+      onError: ref.read(appExceptionNotifierProvider.notifier).notify,
     );
   }
 }