Merge pull request #262 from yumemi-inc/feature/refactor_navigation

Navigatorのインターフェースをfeatureのuiに定義するように変更し、navigationパッケージを廃止

apps/app/lib/router/provider/router.dart

@@ -1,17 +1,15 @@
 import 'package:cores_core/app_status.dart';
 import 'package:cores_core/util.dart';
 import 'package:cores_designsystem/common_assets.dart';
-import 'package:cores_navigation/providers.dart';
 import 'package:features_debug_mode/ui.dart';
 import 'package:features_github_repository/ui.dart';
-import 'package:features_setting/setting.dart';
+import 'package:features_setting/ui.dart';
 import 'package:features_webview/webview.dart';
 import 'package:flutter/foundation.dart';
 import 'package:flutter/material.dart';
 import 'package:flutter_app/main_page.dart';
-import 'package:flutter_app/router/navigator/home_navigator.dart';
-import 'package:flutter_app/router/navigator/setting_navigator.dart';
 import 'package:flutter_app/ui/home_page.dart';
+import 'package:flutter_app/ui/provider/navigator_provider.dart';
 import 'package:flutter_riverpod/flutter_riverpod.dart';
 import 'package:go_router/go_router.dart';
 import 'package:riverpod_annotation/riverpod_annotation.dart';

apps/app/lib/router/routes/main/home/home_shell_branch.dart

@@ -23,6 +23,34 @@ class HomeShellBranch extends StatefulShellBranchData {
   const HomeShellBranch();
 }
 
+final class _HomePageNavigatorImpl implements HomePageNavigator {
+  const _HomePageNavigatorImpl();
+
+  @override
+  void goDebugPage(BuildContext context) {
+    const DebugPageRoute().go(context);
+  }
+
+  @override
+  void goWebPage(BuildContext context) {
+    const WebPageRoute().go(context);
+  }
+}
+
+final class _GithubRepositoryListPageNavigatorImpl
+    implements GitHubRepositoryListPageNavigator {
+  const _GithubRepositoryListPageNavigatorImpl();
+
+  @override
+  void goGitHubRepositoryDetailPage(
+    BuildContext context,
+    String repositoryName,
+    String? description,
+  ) {
+    GitHubRepositoryDetailPageRoute(repositoryName, description).go(context);
+  }
+}
+
 class HomePageRoute extends GoRouteData {
   const HomePageRoute();
 
@@ -39,7 +67,11 @@ class HomePageRoute extends GoRouteData {
       // navigation or the state.
       child: ProviderScope(
         overrides: [
-          homeNavigatorProvider.overrideWithValue(const HomeNavigatorImpl()),
+          homePageNavigatorProvider
+              .overrideWithValue(const _HomePageNavigatorImpl()),
+          gitHubRepositoryListPageNavigatorProvider.overrideWithValue(
+            const _GithubRepositoryListPageNavigatorImpl(),
+          ),
         ],
         child: const HomePage(),
       ),

apps/app/lib/router/routes/main/setting/setting_shell_branch.dart

@@ -17,6 +17,15 @@ class SettingShellBranch extends StatefulShellBranchData {
   const SettingShellBranch();
 }
 
+final class _SettingPageNavigatorImpl implements SettingPageNavigator {
+  const _SettingPageNavigatorImpl();
+
+  @override
+  void goLicensePage(BuildContext context) {
+    const LicensePageRoute().go(context);
+  }
+}
+
 class SettingPageRoute extends GoRouteData {
   const SettingPageRoute();
 
@@ -26,8 +35,8 @@ class SettingPageRoute extends GoRouteData {
   Widget build(BuildContext context, GoRouterState state) {
     return ProviderScope(
       overrides: [
-        settingNavigatorProvider.overrideWithValue(
-          const SettingNavigatorImpl(),
+        settingPageNavigatorProvider.overrideWithValue(
+          const _SettingPageNavigatorImpl(),
         ),
       ],
       child: const SettingPage(),

apps/app/lib/ui/home_page.dart

@@ -1,10 +1,15 @@
 import 'package:cores_designsystem/theme_extensions.dart';
-import 'package:cores_navigation/providers.dart';
 import 'package:features_github_repository/ui.dart';
 import 'package:flutter/material.dart';
 import 'package:flutter_app/gen/l10n/l10n.dart';
+import 'package:flutter_app/ui/provider/navigator_provider.dart';
 import 'package:flutter_riverpod/flutter_riverpod.dart';
 
+abstract interface class HomePageNavigator {
+  void goDebugPage(BuildContext context);
+  void goWebPage(BuildContext context);
+}
+
 class HomePage extends ConsumerWidget {
   const HomePage({
     super.key,
@@ -13,7 +18,7 @@ class HomePage extends ConsumerWidget {
   @override
   Widget build(BuildContext context, WidgetRef ref) {
     final l = L10n.of(context);
-    final navigator = ref.watch(homeNavigatorProvider);
+    final navigator = ref.watch(homePageNavigatorProvider);
     return Scaffold(
       appBar: AppBar(
         title: Text(l.appBar),
@@ -35,7 +40,7 @@ class HomePage extends ConsumerWidget {
           color: context.appColors.icon,
         ),
       ),
-      body: const GitHubRepositoryList(),
+      body: const GitHubRepositoryListPage(),
     );
   }
 }

apps/app/lib/ui/provider/navigator_provider.dart

@@ -0,0 +1,8 @@
+import 'package:flutter_app/ui/home_page.dart';
+import 'package:riverpod_annotation/riverpod_annotation.dart';
+
+part 'navigator_provider.g.dart';
+
+@Riverpod(dependencies: [])
+HomePageNavigator homePageNavigator(HomePageNavigatorRef ref) =>
+    throw UnimplementedError();

apps/app/pubspec.lock

@@ -221,13 +221,6 @@ packages:
       relative: true
     source: path
     version: "0.0.1"
-  cores_navigation:
-    dependency: "direct main"
-    description:
-      path: "../../packages/cores/navigation"
-      relative: true
-    source: path
-    version: "0.0.1"
   coverage:
     dependency: transitive
     description:

apps/app/pubspec.yaml

@@ -16,8 +16,6 @@ dependencies:
     path: ../../packages/cores/designsystem
   cores_init:
     path: ../../packages/cores/init
-  cores_navigation:
-    path: ../../packages/cores/navigation
   features_debug_mode:
     path: ../../packages/features/debug_mode
   features_github_repository: