WebViewの初回Loadingとpull-to-refreshの実装 #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iseruuuuu
changed the title
iseruuuuu
changed the title
iseruuuuu
changed the title
|
Ready for review 🚀 |
iseruuuuu
changed the title
|
Ready for review 🚀 |
|
@warahiko @Yamasaki-pan961 |
|
@iseruuuuu |
iseruuuuu
changed the title
iseruuuuu
commented
Feb 7, 2024
Comment on lines
+90
to
+96
| onProgressChanged: (_, __) async { | ||
| if (await _webViewController!.canGoBack()) { | ||
| canPop.value = false; | ||
| } else { | ||
| canPop.value = true; | ||
| } | ||
| }, |
There was a problem hiding this comment.
次のページに遷移したときや戻ったときに毎回呼ばれるメソッドだと判断し、canPopの制御・管理の記載をしてみました
Yamasaki-pan961
approved these changes
Feb 7, 2024
|
LGTMいただきありがとうございます！！！ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
概要
#26 の途中までのPRとなります
レビュー観点
レビューレベル
レビュー優先度
画像 / 動画
Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-02-06.at.10.24.58.mp4
untitled.webm
動作確認手順
備考