ci: PR 確認用の Firebase Hosting デプロイワークフローを追加 #111
Conversation
|
Visit the preview URL for this PR (updated for commit a762de2): https://flutter-mobile-project-template-catalog--pr111-feature-9j86jonu.web.app (expires Tue, 20 Feb 2024 08:16:04 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 9ea56735a63d07a7cfe62eb204b0528284c37c23 |
…to feature/add-firebase-hosting
tatsutakein
changed the title
| { | ||
| "hosting": [ | ||
| { | ||
| "target": "catalog", | ||
| "source": "apps/catalog", | ||
| "ignore": [ | ||
| "firebase.json", | ||
| "**/.*" | ||
| ], | ||
| "frameworksBackend": { | ||
| "region": "asia-east1" | ||
| } | ||
| } | ||
| ] | ||
| } |
There was a problem hiding this comment.
Firebase のドキュメント を参考にフレームワーク対応の Hosting で構築しています
There was a problem hiding this comment.
Firebase のドキュメント を参考に構築しています。
| steps: | ||
| # https://github.com/marketplace/actions/checkout | ||
| - name: Checkout | ||
| uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1 |
There was a problem hiding this comment.
以下の記事の「サードパーティのActionを利用する場合の対応」を参考に Full Changeset Hash で指定しています。
https://engineering.mercari.com/blog/entry/20230609-github-actions-guideline/
There was a problem hiding this comment.
とても勉強になります！
他のワークフローの指定もいずれ修正したいですね👍
| ## 4. Change workflow content | ||
|
|
||
| Modify `.github/workflows/firebase-hosting-pull-request.yaml`. | ||
|
|
||
| ### 4-1. Remove repository name condition | ||
|
|
||
| To avoid inadvertent execution of the workflow when a new project is created based on this template project, we have | ||
| included an activation condition by repository name. | ||
| This description is no longer needed during setup, so please delete it. | ||
|
|
||
|  | ||
|
|
||
| ### 4-2. Change Firebase Service Account name | ||
|
|
||
| Replace with the name of the Firebase Service Account created by the `firebase init hosting:github` command. | ||
|
|
||
|  | ||
|
|
||
| ### 4-3. Change projectId to the ID of the relevant project | ||
|
|
||
| Replace the Firebase project. | ||
|
|
||
|  |
There was a problem hiding this comment.
どこを変更するのかがテキストのみだと伝わりにくいかなと思い、画像も追加しています。
|
Ready for review 🚀 |
| steps: | ||
| # https://github.com/marketplace/actions/checkout | ||
| - name: Checkout | ||
| uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1 |
There was a problem hiding this comment.
とても勉強になります！
他のワークフローの指定もいずれ修正したいですね👍
Co-authored-by: trm11tkr <89247188+trm11tkr@users.noreply.github.com>
tatsutakein
force-pushed
the
feature/add-firebase-hosting
branch
from
9b1207b
to
a762de2
Compare
|
@trm11tkr |
Issue
概要
Firebase Hosting のデプロイワークフローを追加します。
レビュー観点
docs/FIREBASE_HOSTING_PREVIEW.md) を確認して作業を実施することで、新たなプロジェクトでもスムーズにセットアップができそうかレビューレベル
レビュー優先度
画像 / 動画
動作確認手順
備考