Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI高速化 #221

Merged
merged 9 commits into from
Jun 4, 2024
Merged

CI高速化 #221

merged 9 commits into from
Jun 4, 2024

Conversation

K9i-0
Copy link
Contributor

@K9i-0 K9i-0 commented Jun 4, 2024

概要

close #19
close #191

  • CIを高速化するための設定変更
    • flutter setupでcacheを有効化
    • custom_lintのjobをcheckから分離し、mainに向いたブランチでのみ実行するように設定

レビュー観点

レビューレベル

  • Lv1: ぱっとみて違和感がないかチェックして Approve する
  • Lv2: 仕様レベルまで理解して、仕様通りに動くかある程度検証して Approve する
  • Lv3: 実際に環境で動作確認したうえで Approve する

レビュー優先度

  • すぐに見てもらいたい ( hotfix など ) 🚀
  • 今日中に見てもらいたい 🚗
  • 今日〜明日中で見てもらいたい 🚶
  • 数日以内で見てもらいたい 🐢

画像 / 動画

Before After Design

動作確認手順

custom_lintがある時で3分くらい、なければ1分ちょっと
image

備考

Copy link

github-actions bot commented Jun 4, 2024

Visit the preview URL for this PR (updated for commit 514494b):

https://flutter-mobile-project-template-catalog--pr221-feature-pqzyfvpu.web.app

(expires Tue, 11 Jun 2024 07:02:10 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 9ea56735a63d07a7cfe62eb204b0528284c37c23

@K9i-0 K9i-0 marked this pull request as ready for review June 4, 2024 02:19
@yumemi-team-review-requester yumemi-team-review-requester bot requested review from a team, morikann and trm11tkr and removed request for a team June 4, 2024 02:19
Copy link

github-actions bot commented Jun 4, 2024

Ready for review 🚀

blendthink
blendthink previously approved these changes Jun 4, 2024
Copy link
Member

@blendthink blendthink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@K9i-0
ご対応ありがとうございます!
コメントしていますが、特に問題はないため LGTM させていただきます!
修正するかどうかはお任せします 🙏

.github/workflows/check-pr.yaml Outdated Show resolved Hide resolved
.github/workflows/check-pr.yaml Outdated Show resolved Hide resolved
@K9i-0 K9i-0 requested a review from blendthink June 4, 2024 06:50
# Conflicts:
#	.github/workflows/check-pr.yaml
Base automatically changed from feature/new_format to main June 4, 2024 07:03
@K9i-0 K9i-0 dismissed blendthink’s stale review June 4, 2024 07:03

The base branch was changed.

@K9i-0 K9i-0 enabled auto-merge June 4, 2024 07:03
@K9i-0 K9i-0 merged commit f7f3a68 into main Jun 4, 2024
6 checks passed
@K9i-0 K9i-0 deleted the feature/fast_ci branch June 4, 2024 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants