[GH-257] Android Application ID と iOS Bundle ID を別々にリネームできるようにする #258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yumemi-team-review-requester
bot
requested review from
a team,
Aosanori and
morikann
and removed request for
a team
|
Ready for review 🚀 |
daichikuwa0618
commented
Jun 13, 2024
There was a problem hiding this comment.
差分も確認いただきたいですが、 https://github.com/yumemi-inc/flutter-mobile-project-template/blob/feature/GH-257/.github/initialization/RENAME_APPLICATION_ID.md で完成後のドキュメントが問題ないかも見ていただきたいです。
Comment on lines
-4
to
+5
| "appId": "jp.co.yumemi.template", | ||
| "appIdAndroid": "jp.co.yumemi.template", | ||
| "appIdIos": "jp.co.yumemi.template", |
There was a problem hiding this comment.
Ios はかなり気持ち悪いが、、、、
androidAppId/iosAppIdはアルファベット順で並べたときに離れてしまう- lower camel case 遵守
ということでこの命名を採用してます。
Comment on lines
-19
to
-20
| readonly NEW_APPLICATION_ID=$1 | ||
| readonly OLD_APPLICATION_ID="jp.co.yumemi.template" |
There was a problem hiding this comment.
削除した 2 変数が使われてないことは grep で確認済み
daichikuwa0618
commented
Jun 13, 2024
Comment on lines
-19
to
-20
| ```bash | ||
| bash rename-application-id.sh "com.example.rename" |
There was a problem hiding this comment.
macOS のデフォルトは zsh だし、シェルスクリプトのシバンも /bin/sh なので bash に限定しなくてもいいかなと。
K9i-0
requested changes
Jun 13, 2024
There was a problem hiding this comment.
修正に関してはLGTM
既存がおかしいのでSlackにコメントしました
https://yumemi.slack.com/archives/C0585H2BG9L/p1718275216573499
daichikuwa0618
force-pushed
the
feature/GH-257
branch
from
1dc8ad0
to
0f63f12
Compare
|
@K9i-0 さんに Slack にて指摘してもらった点:
でした。 1 については bf4d290 に混ぜて修正しました (分けると良くわからないまとまりになりそうだったので)。 diff beforediff --git a/apps/app/android/app/src/main/kotlin/jp/co/yumemi/flutter_app/MainActivity.kt b/apps/app/android/app/src/main/kotlin/jp/co/yumemi/flutter_app/MainActivity.kt
deleted file mode 100644
index ccc7325..0000000
--- a/apps/app/android/app/src/main/kotlin/jp/co/yumemi/flutter_app/MainActivity.kt
+++ /dev/null
@@ -1,5 +0,0 @@
-package jp.co.yumemi.flutter_app
-
-import io.flutter.embedding.android.FlutterActivity
-
-class MainActivity: FlutterActivity()
diff --git a/apps/app/flavor/dev.json b/apps/app/flavor/dev.json
index 5ba9ec3..6b06e89 100644
--- a/apps/app/flavor/dev.json
+++ b/apps/app/flavor/dev.json
@@ -1,6 +1,6 @@
{
"flavor": "dev",
"appName": "dev-Template",
- "appId": "jp.co.yumemi.template",
+ "appId": "jp.example.replaced",
"appIdSuffix": ".dev"
}
diff --git a/apps/app/flavor/prd.json b/apps/app/flavor/prd.json
index c6dcb85..6b0ff02 100644
--- a/apps/app/flavor/prd.json
+++ b/apps/app/flavor/prd.json
@@ -1,6 +1,6 @@
{
"flavor": "prd",
"appName": "Template",
- "appId": "jp.co.yumemi.template",
+ "appId": "jp.example.replaced",
"appIdSuffix": ""
}
diff --git a/apps/app/flavor/stg.json b/apps/app/flavor/stg.json
index 0e7698c..857f27b 100644
--- a/apps/app/flavor/stg.json
+++ b/apps/app/flavor/stg.json
@@ -1,6 +1,6 @@
{
"flavor": "stg",
"appName": "stg-Template",
- "appId": "jp.co.yumemi.template",
+ "appId": "jp.example.replaced",
"appIdSuffix": ".stg"
}diff afterdiff --git a/apps/app/android/app/src/main/kotlin/jp/co/yumemi/flutter_app/MainActivity.kt b/apps/app/android/app/src/main/kotlin/jp/co/yumemi/flutter_app/MainActivity.kt
deleted file mode 100644
index ccc7325..0000000
--- a/apps/app/android/app/src/main/kotlin/jp/co/yumemi/flutter_app/MainActivity.kt
+++ /dev/null
@@ -1,5 +0,0 @@
-package jp.co.yumemi.flutter_app
-
-import io.flutter.embedding.android.FlutterActivity
-
-class MainActivity: FlutterActivity()
diff --git a/apps/app/android/app/src/main/kotlin/jp/example/and/MainActivity.kt b/apps/app/android/app/src/main/kotlin/jp/example/and/MainActivity.kt
index e69de29..a719307 100644
--- a/apps/app/android/app/src/main/kotlin/jp/example/and/MainActivity.kt
+++ b/apps/app/android/app/src/main/kotlin/jp/example/and/MainActivity.kt
@@ -0,0 +1,5 @@
+package jp.example.and
+
+import io.flutter.embedding.android.FlutterActivity
+
+class MainActivity: FlutterActivity()
diff --git a/apps/app/flavor/dev.json b/apps/app/flavor/dev.json
index a1c7dae..c87ba18 100644
--- a/apps/app/flavor/dev.json
+++ b/apps/app/flavor/dev.json
@@ -1,7 +1,7 @@
{
"flavor": "dev",
"appName": "dev-Template",
- "appIdAndroid": "jp.co.yumemi.template",
- "appIdIos": "jp.co.yumemi.template",
+ "appIdAndroid": "jp.example.and",
+ "appIdIos": "jp.example.ios",
"appIdSuffix": ".dev"
}
diff --git a/apps/app/flavor/prd.json b/apps/app/flavor/prd.json
index 189021c..0809680 100644
--- a/apps/app/flavor/prd.json
+++ b/apps/app/flavor/prd.json
@@ -1,7 +1,7 @@
{
"flavor": "prd",
"appName": "Template",
- "appIdAndroid": "jp.co.yumemi.template",
- "appIdIos": "jp.co.yumemi.template",
+ "appIdAndroid": "jp.example.and",
+ "appIdIos": "jp.example.ios",
"appIdSuffix": ""
}
diff --git a/apps/app/flavor/stg.json b/apps/app/flavor/stg.json
index 00f0eea..b0743a9 100644
--- a/apps/app/flavor/stg.json
+++ b/apps/app/flavor/stg.json
@@ -1,7 +1,7 @@
{
"flavor": "stg",
"appName": "stg-Template",
- "appIdAndroid": "jp.co.yumemi.template",
- "appIdIos": "jp.co.yumemi.template",
+ "appIdAndroid": "jp.example.and",
+ "appIdIos": "jp.example.ios",
"appIdSuffix": ".stg"
} |
K9i-0
approved these changes
Jun 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
概要
resolve #257
設定をまとめたファイルを作ってパースさせる案もあったが、一回限りのスクリプトに割くには見合っていないということで最小限の変更で対応。
#203 の対応時にあらためて検討されたい。
レビュー観点
レビューレベル
レビュー優先度
確認したこと
参考: 修正前の実行後
修正後の実行後差分
cd tools sh rename-application-id.sh com.example.android.rename com.example.ios.rename動作確認手順
cd tools sh rename-application-id.sh com.example.android.rename com.example.ios.rename備考