-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PR の解析・テストを行うワークフロー追加 #37
Conversation
fb305d4
to
f00962f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
解析失敗時
https://github.com/yumemi-inc/flutter-mobile-project-template/actions/runs/7334934850
https://github.com/yumemi-inc/flutter-mobile-project-template/actions/runs/7335488121
テスト失敗時
https://github.com/yumemi-inc/flutter-mobile-project-template/actions/runs/7335238482
https://github.com/yumemi-inc/flutter-mobile-project-template/actions/runs/7335238482/job/19972959216
|
||
- name: Setup melos | ||
run: | | ||
ln -s $FLUTTER_ROOT .fvm/flutter_sdk |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
melos.yaml で指定しているため必要
@@ -5,22 +5,20 @@ targets: | |||
# https://github.com/dart-lang/build/blob/master/docs/faq.md#how-do-i-avoid-running-builders-on-unnecessary-inputs | |||
generate_for: | |||
include: | |||
- lib/model/*.dart | |||
- lib/**/model/*.dart | |||
- lib/{model,**/model}/**.dart |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lib/model などが必要かどうかは微妙?
マルチパッケージにするなら直下に生えることはあるかも、とは思った
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ここどうするかは悩ましいですが、いったんこのままでいいかなと思いました、、!
(というか、このような中括弧をつかった書き方ができるのですね)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
中で https://pub.dev/packages/glob を使ってるみたいで、このページ参考にしました!
Ready for review 🚀 |
.github/workflows/check-pr.yaml
Outdated
fatal-infos: true | ||
|
||
- name: Run test | ||
run: melos run test --no-select |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
881b467
to
f00962f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
|
||
scripts: | ||
report_test: | ||
exec: flutter test --no-pub --machine > test_report.log |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
--machine
オプションで json 形式で標準出力する。
気になる点
flutter test --help
で表示されるオプションに --machine
オプションが記載されていない。
その一方で、 --reporter
というオプションでテスト結果の出力形式を json に指定できる模様。
ただし、--machine
と --reporter
オプションで出力される内容に差異がありそう。
-r, --reporter Set how to print test results. If unset, value will default to either compact or expanded.
[compact] A single line that updates dynamically (The default reporter).
[expanded] A separate line for each update. May be preferred when logging to a file or in continuous integration.
[github] A custom reporter for GitHub Actions (the default reporter when running on GitHub Actions).
[json] A machine-readable format. See: https://dart.dev/go/test-docs/json_reporter.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ご対応ありがとうございます!
LGTMです!🎉
@blendthink @Kotaro666-dev @morikann |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
コンフリクト解消ありがとうごいました!
LGTM!!
レビューありがとうございました、こちらマージします! |
概要
close #7
レビュー観点
レビューレベル
レビュー優先度