Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

アクセストークンの指定がない場合に通信失敗する問題の修正 #38

Merged
merged 2 commits into from
Jan 10, 2024
Merged

アクセストークンの指定がない場合に通信失敗する問題の修正 #38

merged 2 commits into from
Jan 10, 2024

Conversation

warahiko
Copy link
Contributor

概要

表題の問題があったため、処理を修正

レビュー観点

  • アクセストークンの指定がない場合に通信ができる
    • リクエストのヘッダを追加しない
  • アクセストークンの指定がある場合に通信ができる

レビューレベル

  • Lv1: ぱっとみて違和感がないかチェックして Approve する
  • Lv2: 仕様レベルまで理解して、仕様通りに動くかある程度検証して Approve する
  • Lv3: 実際に環境で動作確認したうえで Approve する

レビュー優先度

  • すぐに見てもらいたい ( hotfix など ) 🚀
  • 今日中に見てもらいたい 🚗
  • 今日〜明日中で見てもらいたい 🚶
  • 数日以内で見てもらいたい 🐢

動作確認手順

  1. 起動時にアクセストークン（GITHUB_ACCESS_TOKEN）を指定(する|しない)
  2. 起動し、通信が成功することを確認する

@warahiko warahiko marked this pull request as ready for review December 27, 2023 06:13
@github-actions GitHub Actions
Copy link

Ready for review 🚀

blendthink
blendthink reviewed Dec 27, 2023
View reviewed changes
Copy link
Member

@blendthink blendthink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@warahiko
少しだけコメントいたしましたのでご確認お願いします 🙏

apps/app/lib/data/provider/github_access_token.dart Outdated Show resolved Hide resolved
apps/app/lib/data/provider/github_access_token.dart Show resolved Hide resolved
blendthink
blendthink previously approved these changes Dec 27, 2023
View reviewed changes
Copy link
Member

@blendthink blendthink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

morikann
morikann previously approved these changes Jan 4, 2024
View reviewed changes
Copy link
Contributor

@morikann morikann left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ご対応ありがとうございます！
LGTMです！

Base automatically changed from feature/add_check_action to main January 10, 2024 03:57
@warahiko warahiko dismissed stale reviews from morikann and blendthink January 10, 2024 03:57

The base branch was changed.

@warahiko
Copy link
Contributor Author

@blendthink @morikann
retarget が行われたので、お手数ですがご確認よろしくお願いします 🙏

blendthink
blendthink approved these changes Jan 10, 2024
View reviewed changes
Copy link
Member

@blendthink blendthink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@warahiko
Copy link
Contributor Author

レビューありがとうございました！マージします

@warahiko warahiko merged commit 185dace into main Jan 10, 2024
2 checks passed
@warahiko warahiko deleted the feature/fix_getting_access_token branch January 10, 2024 04:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blendthink blendthink blendthink approved these changes

@morikann morikann morikann left review comments

@Yamasaki-pan961 Yamasaki-pan961 Awaiting requested review from Yamasaki-pan961

Assignees

@warahiko warahiko

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@warahiko @blendthink @morikann