Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

開発において必要な内容をGET_STARTED.mdに記載 #42

Closed
wants to merge 2 commits into from
Closed

開発において必要な内容をGET_STARTED.mdに記載 #42

wants to merge 2 commits into from

Conversation

iseruuuuu
Copy link
Contributor

@iseruuuuu iseruuuuu commented Jan 5, 2024 •
edited
Loading

概要

  • 開発において必要な内容をGET_STARTED.mdに記載しました。

チケット

レビュー観点

レビューレベル

  • Lv1: ぱっとみて違和感がないかチェックして Approve する
  • Lv2: 仕様レベルまで理解して、仕様通りに動くかある程度検証して Approve する
  • Lv3: 実際に環境で動作確認したうえで Approve する

レビュー優先度

  • すぐに見てもらいたい ( hotfix など ) 🚀
  • 今日中に見てもらいたい 🚗
  • 今日〜明日中で見てもらいたい 🚶
  • 数日以内で見てもらいたい 🐢

画像 / 動画

  • こちらからGET_STARTED.mdが確認できます。

https://github.com/yumemi-inc/flutter-mobile-project-template/blob/7dc9a14f2221cd0db92780ff617aba0e5c449ca8/docs/GET_STARTED.md

Before After Design

動作確認手順

備考

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 5, 2024

Ready for review 🚀

@iseruuuuu iseruuuuu changed the title 開発において必要な内容をGET_STARTED.mdに記載しました。 開発において必要な内容をGET_STARTED.mdに記載 Jan 5, 2024
@iseruuuuu iseruuuuu requested review from blendthink and removed request for warahiko and morikann January 5, 2024 04:24
@blendthink blendthink requested review from warahiko and morikann and removed request for blendthink January 5, 2024 05:21
blendthink
blendthink reviewed Jan 9, 2024
View reviewed changes
Copy link
Member

@blendthink blendthink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@iseruuuuu
コメントさせていただきましたので、ご確認お願いします 🙏

docs/GET_STARTED.md Outdated Show resolved Hide resolved
docs/GET_STARTED.md Show resolved Hide resolved
blendthink
blendthink approved these changes Jan 10, 2024
View reviewed changes
Copy link
Member

@blendthink blendthink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iseruuuuu
Copy link
Contributor Author

iseruuuuu commented Jan 10, 2024 •
edited
Loading

@blendthink
LGTMいただきありがとうございます〜！
マージしようかなと思っていましたが、以下の記載があったのでひとまず待機で別の作業をします。

レビュアは [vars.REVIEWERS](https://github.com/yumemi-inc/flutter-mobile-project-template/settings/variables/actions) の中からランダムに２名設定されます。その中の１名から Approve されたら Pull Request 提出者はマージしてください。

https://github.com/yumemi-inc/flutter-mobile-project-template/wiki/%E9%81%8B%E7%94%A8%E3%81%AB%E3%81%A4%E3%81%84%E3%81%A6

warahiko
warahiko approved these changes Jan 10, 2024
View reviewed changes
Copy link
Contributor

@warahiko warahiko left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ご対応ありがとうございます！ LGTM 👍
（ただ署名なくて怒られてますね......

@iseruuuuu
Copy link
Contributor Author

#47
こちらで再度作り直したので、Closeさせていただきます🙇

@iseruuuuu iseruuuuu closed this Jan 10, 2024
@blendthink blendthink deleted the feature/add_get_started branch January 29, 2024 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@warahiko warahiko warahiko approved these changes

@blendthink blendthink blendthink approved these changes

@morikann morikann Awaiting requested review from morikann

Assignees

@iseruuuuu iseruuuuu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

docs/GET_STARTED.md の中身を記載
3 participants
@iseruuuuu @warahiko @blendthink