多言語対応 #43
Closed
多言語対応 #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ready for review 🚀 |
|
Ready for review 🚀 |
iseruuuuu
commented
Jan 9, 2024
Comment on lines
+1
to
+11
| // ignore_for_file: type=lint | ||
|
|
||
| import 'l10n.dart'; | ||
|
|
||
| /// The translations for English (`en`). | ||
| class L10nEn extends L10n { | ||
| L10nEn([String locale = 'en']) : super(locale); | ||
|
|
||
| @override | ||
| String get appBar => 'Flutter Template'; | ||
| } |
There was a problem hiding this comment.
[メモ]
この辺りの生成ファイルは.gitattributesを作成して、追記してもいいかもしれないなと思いました。
ご意見をぜひいただけると嬉しいです！
|
@Yamasaki-pan961 @warahiko |
# Conflicts: # apps/app/lib/main.dart
|
こちらのPRも署名Commitができていなかったので、再度作り直します |
|
#48 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
概要
多言語対応を行いました。
マルチパッケージ構成でも使いやすいようにする対応は別PRで実装予定です。
close 多言語対応 #3
タスク
MaterialAppに必要な記載を行う。レビューする上で伝えておきたいこと
HomeScreenを追加して、そちらに記載しました。もし、他にいい書き方があれば、コメントいただけると幸いです！ソース：https://github.com/orgs/yumemi-inc/projects/8/views/1?pane=issue&itemId=47955129
l10n.yamlの記載内容は、以下のIssuesを参考にしました。ソース：https://github.com/orgs/yumemi-inc/projects/8/views/1?pane=issue&itemId=47955129
レビュー観点
レビューレベル
レビュー優先度
画像 / 動画
動作確認手順
備考