Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python package ? #10

Closed
sahitono opened this issue May 5, 2020 · 10 comments
Closed

python package ? #10

sahitono opened this issue May 5, 2020 · 10 comments

Comments

@sahitono
Copy link

sahitono commented May 5, 2020

Hi, why not create python wheel and conda package ? I think it will be easier to use, install and manage. People who use it won't need to bother about installing dependencies and setting up environment variable.

@yumorishita
Copy link
Owner

Thank you for your suggestion. I am sorry for bothering every user to prepare the python environment, but indeed I am not very familiar with python environment. I would like to focus on developing technical things about InSAR at the moment. I would appreciate if someone could share the easy way to create the environment.

@sahitono
Copy link
Author

sahitono commented May 5, 2020

It can be done with github action. I can help to set it up, but the project directory need to be restructured.
This project is great, thank you for creating it.

Repository owner deleted a comment from gpsovsicori Jul 7, 2020
@yumorishita
Copy link
Owner

I have uploaded LiCSBAS.yml to create an "licsbas" environment by conda, and also updated the wiki page. Do you think it is useful? @sahitono

@sahitono
Copy link
Author

@yumorishita that's useful for creating anaconda environment. I think it will be better to include the package version too, so there wont be a problem when installs different major version. Because conda sometimes install gdal version 2 not gdal 3.

Btw I have ported the bash script into powershell script so it can be used by windows user too. i can give it to you, if you are interested with it.

@yumorishita
Copy link
Owner

Thank you for your comments. I agree that the package version should be included, but I don't know what version can work or not for each package. I thought the latest version is installed without the explicit version and it would make no problem.

I have never used powershell. I would appreciate if you could upload the script on your repository or somewhere. I will link to it.

@sahitono
Copy link
Author

What if the package version is the major version of what you currently uses ?

I'll create a fork of it asap, because i made some changes in the joining of url path. Because os.path in windows is backslash which is not a valid url path, so i use posix.path instead os.path.

@yumorishita
Copy link
Owner

I basically use the latest version, but it is not always required. I wonder if the unnecessary version specification increases conflict of multiple packages. LiCSBAS should not require the latest version for a certain package. If no specification of the package version does not cause a significant problem, I would like to keep the current yml file.

@sahitono
Copy link
Author

I think there won't be significant problem

@Zeeshan-Ali1992
Copy link

@yumorishita that's useful for creating anaconda environment. I think it will be better to include the package version too, so there wont be a problem when installs different major version. Because conda sometimes install gdal version 2 not gdal 3.

Btw I have ported the bash script into powershell script so it can be used by windows user too. i can give it to you, if you are interested with it.

Hello sahitono. Kindly share the "bash script" which you added to Powershell script to run it using Windows OS also.

@sahitono
Copy link
Author

@Zeeshan-Ali1992 Hi, sadly I don't recommend it to you because I modified the old version of LiCSBAS to be compatible with windows. I recommend you to use WSL to run Linux on windows simultaneously without VM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants