Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Catch-All parameters when using config.CatchAll #129

Merged
merged 2 commits into from
Jan 16, 2024

Conversation

ginger51011
Copy link
Collaborator

The old implementation could fail to match for example /.git/config, but also nested paths such as /example/here.

See fasthttp/router docs for Catch-All here.

Solves #99

The old implementation could fail to match for example
`/git/config`, but also nested paths such as `/example/here`.

See https://pkg.go.dev/github.com/fasthttp/router#readme-catch-all-parameters
@yunginnanet
Copy link
Owner

yunginnanet commented Jan 16, 2024

Nice catch

@yunginnanet yunginnanet linked an issue Jan 16, 2024 that may be closed by this pull request
Copy link
Owner

@yunginnanet yunginnanet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@yunginnanet yunginnanet merged commit 39e49f3 into yunginnanet:main Jan 16, 2024
1 check passed
@yunginnanet
Copy link
Owner

/release tag=v0.4.1

yunginnanet pushed a commit that referenced this pull request Jun 26, 2024
* Use Catch-All parameters when using config.CatchAll

The old implementation could fail to match for example
`/git/config`, but also nested paths such as `/example/here`.

See https://pkg.go.dev/github.com/fasthttp/router#readme-catch-all-parameters

* Run go fmt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some URLs are not picked up by HellPot
2 participants