fix: Hanle the error of vdisk.GetIStorage in syncCloudDisk

yunionio · Jun 9, 2020 · 4c66826 · 4c66826
1 parent f441306
commit 4c66826
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/pkg/compute/models/disks.go b/pkg/compute/models/disks.go
@@ -1218,7 +1218,10 @@ func (manager *SDiskManager) syncCloudDisk(ctx context.Context, userCred mcclien
 	diskObj, err := db.FetchByExternalId(manager, vdisk.GetGlobalId())
 	if err != nil {
 		if err == sql.ErrNoRows {
-			vstorage, _ := vdisk.GetIStorage()
+			vstorage, err := vdisk.GetIStorage()
+			if err != nil {
+				return nil, errors.Wrapf(err, "unable to GetIStorage of vdisk %q", vdisk.GetName())
+			}
 
 			storageObj, err := db.FetchByExternalId(StorageManager, vstorage.GetGlobalId())
 			if err != nil {