修复规则无法禁用的问题

pkg/monitor/models/suggestsysrule.go

@@ -214,18 +214,17 @@ func (self *SSuggestSysRule) GetExtraDetails(
 //after create, update Cronjob's info
 func (self *SSuggestSysRule) PostCreate(ctx context.Context, userCred mcclient.TokenCredential, ownerId mcclient.IIdentityProvider, query jsonutils.JSONObject, data jsonutils.JSONObject) {
 	self.SVirtualResourceBase.PostCreate(ctx, userCred, ownerId, query, data)
-	cronman.GetCronJobManager().Remove(self.Type)
-	if self.Enabled.Bool() {
-		dur, _ := time.ParseDuration(self.Period)
-		cronman.GetCronJobManager().AddJobAtIntervalsWithStartRun(self.Type, dur,
-			suggestSysRuleDrivers[self.Type].DoSuggestSysRule, true)
-	}
+	self.updateCronjob()
 }
 
 //after update, update Cronjob's info
 func (self *SSuggestSysRule) PostUpdate(
 	ctx context.Context, userCred mcclient.TokenCredential,
 	query jsonutils.JSONObject, data jsonutils.JSONObject) {
+	self.updateCronjob()
+}
+
+func (self *SSuggestSysRule) updateCronjob() {
 	cronman.GetCronJobManager().Remove(self.Type)
 	if self.Enabled.Bool() {
 		dur, _ := time.ParseDuration(self.Period)
@@ -246,7 +245,23 @@ func (self *SSuggestSysRule) PerformEnable(ctx context.Context, userCred mcclien
 			return nil
 		})
 		db.OpsLog.LogEvent(self, db.ACT_ENABLE, "", userCred)
-		self.PostUpdate(ctx, userCred, query, data)
+		self.updateCronjob()
+	}
+	return nil, nil
+}
+
+func (self *SSuggestSysRule) AllowPerformDisable(ctx context.Context, userCred mcclient.TokenCredential, query jsonutils.JSONObject, data jsonutils.JSONObject) bool {
+	return db.IsAdminAllowPerform(userCred, self, "disable")
+}
+
+func (self *SSuggestSysRule) PerformDisable(ctx context.Context, userCred mcclient.TokenCredential, query jsonutils.JSONObject, data jsonutils.JSONObject) (jsonutils.JSONObject, error) {
+	if self.Enabled.IsTrue() {
+		db.Update(self, func() error {
+			self.Enabled = tristate.False
+			return nil
+		})
+		db.OpsLog.LogEvent(self, db.ACT_DISABLE, "", userCred)
+		self.updateCronjob()
 	}
 	return nil, nil
 }