fix: 修复vm绑定重复安全组

yunionio · Jul 28, 2020 · f03d021 · f03d021
1 parent 0b8baee
commit f03d021
Showing 1 changed file with 7 additions and 5 deletions.
diff --git a/pkg/compute/models/guests.go b/pkg/compute/models/guests.go
@@ -1713,11 +1713,13 @@ func (guest *SGuest) PostCreate(ctx context.Context, userCred mcclient.TokenCred
 		guest.setUserData(ctx, userCred, userData)
 	}
 	secgroups, _ := jsonutils.GetStringArray(data, "secgroups")
-	for _, secgroup := range secgroups {
-		gs := SGuestsecgroup{}
-		gs.SecgroupId = secgroup
-		gs.GuestId = guest.Id
-		GuestsecgroupManager.TableSpec().Insert(ctx, &gs)
+	for _, secgroupId := range secgroups {
+		if secgroupId != guest.SecgrpId {
+			gs := SGuestsecgroup{}
+			gs.SecgroupId = secgroupId
+			gs.GuestId = guest.Id
+			GuestsecgroupManager.TableSpec().Insert(ctx, &gs)
+		}
 	}
 }