Skip to content

Commit

Permalink
add fuzzy ip matching
Browse files Browse the repository at this point in the history
  • Loading branch information
tangbin committed May 19, 2020
1 parent 4e75083 commit f602979
Show file tree
Hide file tree
Showing 2 changed files with 22 additions and 3 deletions.
6 changes: 5 additions & 1 deletion pkg/apis/compute/network.go
Original file line number Diff line number Diff line change
Expand Up @@ -71,10 +71,14 @@ type NetworkListInput struct {

UsableResourceListInput

// description: search ip address in network.
// description: Exact matching ip address in network.
// example: 10.168.222.1
Ip string `json:"ip"`

// description: Fuzzy matching ip address in network.
// example: 10.168.222.1
IpMatch string `json:"ip_match"`

IfnameHint []string `json:"ifname_hint"`
// 起始IP地址
GuestIpStart []string `json:"guest_ip_start"`
Expand Down
19 changes: 17 additions & 2 deletions pkg/compute/models/networks.go
Original file line number Diff line number Diff line change
Expand Up @@ -1780,8 +1780,17 @@ func (manager *SNetworkManager) ListItemFilter(
}
}

ip := ""
exactIpMatch := false
if len(input.Ip) > 0 {
ipIa, err := parseIpToIntArray(input.Ip)
exactIpMatch = true
ip = input.Ip
} else if len(input.IpMatch) > 0 {
ip = input.IpMatch
}

if len(ip) > 0 {
ipIa, err := parseIpToIntArray(ip)
if err != nil {
return nil, err
}
Expand All @@ -1796,7 +1805,13 @@ func (manager *SNetworkManager) ListItemFilter(
ipStart := sqlchemy.INET_ATON(q.Field("guest_ip_start"))
ipEnd := sqlchemy.INET_ATON(q.Field("guest_ip_end"))

ipCondtion := sqlchemy.OR(sqlchemy.Between(ipField, ipStart, ipEnd), sqlchemy.Contains(q.Field("guest_ip_start"), input.Ip), sqlchemy.Contains(q.Field("guest_ip_end"), input.Ip))
var ipCondtion sqlchemy.ICondition
if exactIpMatch {
ipCondtion = sqlchemy.Between(ipField, ipStart, ipEnd)
} else {
ipCondtion = sqlchemy.OR(sqlchemy.Between(ipField, ipStart, ipEnd), sqlchemy.Contains(q.Field("guest_ip_start"), ip), sqlchemy.Contains(q.Field("guest_ip_end"), ip))
}

q = q.Filter(ipCondtion)
}

Expand Down

0 comments on commit f602979

Please sign in to comment.