feature: filterclause support multiple params. equivalent to the union of multiple single param #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
of multiple single param
swordqiu
requested review from
wanyaoqi and
yousong
and removed request for
tb365
|
/lgtm |
yousong
reviewed
Nov 20, 2019
| } | ||
| return condFunc(field, fc.params, func(f sqlchemy.IQueryField, p string) sqlchemy.ICondition { | ||
| return sqlchemy.Equals(f, p) | ||
| }) |
There was a problem hiding this comment.
这里应该也可以直接用sqlchemy.Equals， 不需要包装？
There was a problem hiding this comment.
sqlchemy.Equals的参数类型是interface{}，这里要求string
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: yousong The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
wanyaoqi
pushed a commit
to wanyaoqi/pkg
that referenced
this pull request
Jan 2, 2020
…bugfix/yousong-trace-log to master * commit '5871460d50827f52bc3c1bfb3f7768f22b9623e4': trace: remove unconditional log on EndTrace
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
改进：filterclause的部分算子支持多个输入参数，等价于单个输入参数的并集