This repository has been archived by the owner on May 20, 2024. It is now read-only.
Breadcrumbs & Pagetitle #161 #242
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
D0nPiano
commented
Dec 22, 2016
D0nPiano
commented
- Design breadcrumbs
- think of a nicer way to change document title
- test
… added it to *Detail pages
# Conflicts: # client/app/components/groupDetail/groupDetail.html # client/app/components/storeDetail/storeDetail.html
# Conflicts: # client/app/components/groupDetail/groupDetail.controller.js # client/app/components/groupDetail/groupDetail.html # client/app/components/userDetail/userDetail.html
Added tests
Added description component for mobile version
groupDetail -> store groupDetail -> group -> members / description / pickups / stores
The test needs to load all modules which define parent routes or the route is not registered and will not be triggered. At the moment the routes do not have a hook to check for authenticated status, so I removed that part of the test too. Current backend will return group info without auth, but not store info. Not sure what is intended.
I think it's much better to understand if every module includes all the things it depends on.
# Conflicts: # client/app/components/_groupMenu/groupMenu.html # client/app/components/_topbar/topbar.html # client/app/components/storeDetail/storeDetail.html
Current coverage is 98.61% (diff: 98.17%)@@ master #242 diff @@
==========================================
Files 108 128 +20
Lines 1680 1801 +121
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 1658 1776 +118
- Misses 22 25 +3
Partials 0 0
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.