This repository has been archived by the owner on May 20, 2024. It is now read-only.
Refactor layouts into components #473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reduces style code in root app
Codecov Report
@@ Coverage Diff @@
## master #473 +/- ##
==========================================
+ Coverage 98.54% 98.56% +0.02%
==========================================
Files 207 215 +8
Lines 2951 2993 +42
==========================================
+ Hits 2908 2950 +42
Misses 43 43
Continue to review full report at Codecov.
|
tiltec
added a commit
that referenced
this pull request
May 6, 2018
* add updatedAtMixin * add updated_at for conversation * fix a test * add migration * adapt migration to code I forgot to add this as migration. Shame on me -.-But it's not stored in the database, therefore I can just rewrite the old migration. * fix test
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Advantages: less code in app.styl, cleaner separation of style responsibilities