Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Order of feedback #2157

Closed
dwaxweiler opened this issue Aug 18, 2020 · 4 comments · Fixed by karrot-dev/karrot-backend#1044 or #2161
Closed

Order of feedback #2157

dwaxweiler opened this issue Aug 18, 2020 · 4 comments · Fixed by karrot-dev/karrot-backend#1044 or #2161

Comments

@dwaxweiler
Copy link
Contributor

In my group, some of us are confused by the current default order of the feedback entries, which are ordered by the date they have been written. Example:

Screenshot_2020-08-18 Karrot

We would find it more logical to order them by default by their pickup's date as one person of us needs to go through them in chronologic order of the pickups. The current order could be offered as a second sorting option.

I also think that the user experience will improve by changing the default order as the pickup date is shown way bigger as the time the feedback entry has been written.

@nicksellen
Copy link
Member

Seems reasonable to me, I created a PR for the backend karrot-dev/karrot-backend#1044 :)

I think we can just change it for everyone, and if somebody wants the old behaviour back, then add an option. This way we don't need any frontend changes, and no more buttons.

@tiltec
Copy link
Member

tiltec commented Aug 18, 2020 via email

@nicksellen
Copy link
Member

I wonder if the frontend has its own sorting logic implemented? It did make sense, because our state is a mixed bucket from different sources/purposes.

It does! Just throwing together a fix...

@nicksellen
Copy link
Member

It's fixed in master now (can see it in action at https://dev.karrot.world/#/group/1/feedback). Will get deployed to production later this week probably :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants