Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resend invitation email (assigned) #837

Closed
djahnie opened this issue Jan 11, 2018 · 9 comments · Fixed by #1246
Closed

Resend invitation email (assigned) #837

djahnie opened this issue Jan 11, 2018 · 9 comments · Fixed by #1246

Comments

@djahnie
Copy link
Member

djahnie commented Jan 11, 2018

I want to add Maxi to foodsharing Wurzen. I sent her an invitation months ago, but she said she never received it.

I'd like to have a possibility to resend the invitation email. E.g with a pop-up that warns me that an invitation was already sent to this address, but still offers me to do it again.

@djahnie
Copy link
Member Author

djahnie commented Jan 11, 2018

LOL after putting great emphasis on the fact that she'd never have overlooked a mail, an hour ago Maxi joined foodsharing Wurzen...^^
So the personally perceived immediate urgency of this issue is gone for me now... 😉

@tiltec
Copy link
Member

tiltec commented Jan 11, 2018

Doesn't the invite expire after a while? Then it can be send again. But I'm not completely sure, need to check in the backend.

@tiltec
Copy link
Member

tiltec commented Jan 11, 2018

Yes, can confirm: invitations expire after 14 days and get removed from the server. Sending again is possible then.

(There might be a chance that the invitations gets not removed from the server because the removal is only triggered when somebody else sends an invitation.)

I guess it would still be sensible to allow sending invitations again a bit earlier. Will leave this as a feature request.

@djahnie
Copy link
Member Author

djahnie commented Jan 11, 2018

Erm okay, that is really strange then... I definitely sent this invitation longer ago than 14 days. And when I tried to do it again I directly got the error message. Could it be that karrot sent the mail anyways, or that I double-clicked and that was enough? Cause otherwise I really don't understand what happened here... 😅

@tiltec
Copy link
Member

tiltec commented Jan 12, 2018

Yes, indeed you sent out the mail some days ago. Probably the earlier invitation was expired and it was possible to send the invitation again. It seems like a frontend bug.

@tiltec
Copy link
Member

tiltec commented Oct 31, 2018

I guess that could be a starter task: implement frontend and backend parts to allow for (limited) resending of invitation emails.

I would imagine to allow resending 1 hour after the invitation has been sent.

@mvellasco
Copy link
Contributor

Can I start working on it?

@tiltec
Copy link
Member

tiltec commented Jan 5, 2019

Hi @mvellasco, welcome! Yes, this seems a good task to get started with.
If you have any questions, you can ask them here or in our Slack channel (see Readme file)

@mvellasco
Copy link
Contributor

Hello @tiltec, thank you for the welcome! I'm just wrapping up the code, and I'll submit a PR on the next day or so.

@tiltec tiltec changed the title Resend invitation email Resend invitation email (WIP) Feb 3, 2019
@tiltec tiltec changed the title Resend invitation email (WIP) Resend invitation email (assigned) Feb 3, 2019
tiltec pushed a commit that referenced this issue May 23, 2019
* Solved issue #837

* Adds requested changes to the code

* resolve conflicts with master branch

* remove validation logic, rely on server instead

* remove translation

* Update CHANGELOG.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants