Skip to content
This repository has been archived by the owner on May 20, 2024. It is now read-only.

Resend invitation email #1246

Merged
merged 7 commits into from May 23, 2019
Merged

Resend invitation email #1246

merged 7 commits into from May 23, 2019

Conversation

mvellasco
Copy link
Contributor

@mvellasco mvellasco commented Jan 28, 2019

Closes #837

Finished the tasks for the frontend.

@codecov
Copy link

codecov bot commented Jan 28, 2019

Codecov Report

Merging #1246 into master will decrease coverage by 0.19%.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #1246     +/-   ##
========================================
- Coverage   57.09%   56.9%   -0.2%     
========================================
  Files         241     241             
  Lines        4743    4759     +16     
  Branches      738     763     +25     
========================================
  Hits         2708    2708             
- Misses       2034    2050     +16     
  Partials        1       1
Impacted Files Coverage Δ
src/invitations/api/invitations.js 16.66% <0%> (-2.09%) ⬇️
src/invitations/datastore/invitations.js 37.73% <0%> (-13.55%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 19a490e...9b0752b. Read the comment docs.

@mvellasco
Copy link
Contributor Author

Hello @tiltec, I made the changes to the code as requested. Hope it's everything alright now.

@tiltec
Copy link
Member

tiltec commented Jan 29, 2019

Part of me likes the solution to implicitly resend the email when typing the same email again. Another part of me wants to have a "resend" button next to the invited email address. Both might be fine as well.
What do you think about the extra button?

(Just some thoughts, I'm happy to accept the current solution)

@mvellasco
Copy link
Contributor Author

I think the button would be better for the users to understand what's going on. I've tried it before but I didn't succeed, I'll try again, and if I can't I'll ask for help on the slack channel.

@tiltec tiltec changed the title Solved issue #837 WIP: Resend invitation email Apr 27, 2019
@mvellasco
Copy link
Contributor Author

Hello @tiltec, good evening!

I'm sorry but I couldn't make the button work, I'm still not familiarized enough with the stack ☹️ I'll continue to improve my skills, and I hope to be able to add this feature soon. Besides that, everything is working nicely by typing the email again.

Best Regards,
Miguel V.

@tiltec tiltec changed the title WIP: Resend invitation email Resend invitation email May 23, 2019
@tiltec tiltec merged commit 8f163b6 into karrot-dev:master May 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Resend invitation email (assigned)
2 participants