Abort postinstall if /etc/yunohost/apps ain't empty #1147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kay0u
approved these changes
Jan 21, 2021
…ch of init step to debian/postinst instead of 'yunohost tools postintall'
kay0u
reviewed
Jan 27, 2021
Co-authored-by: Kayou <pierre@kayou.io>
|
Do you want a hotfix for 4.1 or do we merge it to 4.2? |
|
Hmnah 4.2 is fine ... turns out the issue the original issue was related to the user uninstalling yunohost because of apache2 >_> When a user decided they would just fuck up the system, not sure what we can do ... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem
Once more today, saw this issue where /etc/yunohost/installed mysteriously disappeared following some failed stuff ... (as well as yunohost-admin getting uninstalled ... why the hell ?!). Then user reinstalled yunohost-admin, and the webadmin was like "hey let's run the postinstall" which then miserably crashed
Solution
Test at the beginning of the postinstall if /etc/yunohost/apps exists, and abort if there's at least one app folder inside ... That should be a decent indicator that the system was postinstalled in the past and something funky happened
PR Status
Yolocommited
How to test
Idk try to run postinstall with non-empty /etc/yunohost/apps