Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[enh] Refactor global settings to use the new config panel framework #1459

Merged
merged 37 commits into from Sep 4, 2022
Merged

[enh] Refactor global settings to use the new config panel framework #1459

merged 37 commits into from Sep 4, 2022

Conversation

Tagadda
Copy link
Contributor

@Tagadda Tagadda commented Apr 26, 2022

The problem

...

Solution

...

PR Status

Mostly done, needs testing and unit tests.

How to test

...

@Tagadda Tagadda mentioned this pull request Jun 27, 2022
Closed
@Tagadda Tagadda changed the title Enh global settings configpanel [WIP] global settings configpanel Jun 27, 2022
@Tagadda Tagadda mentioned this pull request Jun 27, 2022
Merged
@theo-is-taken theo-is-taken mentioned this pull request Jun 29, 2022
Closed
alexAubin
alexAubin approved these changes Aug 3, 2022
View reviewed changes
Copy link
Member

@alexAubin alexAubin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quick review, LGTM (only minor comments / thinking out loud about possible improvements later)

locales/en.json Outdated Show resolved Hide resolved
locales/en.json Outdated Show resolved Hide resolved
locales/en.json Outdated Show resolved Hide resolved
locales/en.json Outdated Show resolved Hide resolved
share/config_settings.toml Outdated Show resolved Hide resolved
src/settings.py Outdated Show resolved Hide resolved
src/settings.py Outdated Show resolved Hide resolved
src/settings.py Outdated Show resolved Hide resolved
src/settings.py Show resolved Hide resolved
hooks/conf_regen/19-postfix Show resolved Hide resolved
@alexAubin alexAubin changed the title [WIP] global settings configpanel [enh] Refactor global settings to use the new config panel framework Aug 5, 2022
alexAubin
alexAubin approved these changes Aug 5, 2022
View reviewed changes
Copy link
Member

@alexAubin alexAubin left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM I think, but still have to test on the webadmin

and check if some tests commented are still relevant and can be fixed

@alexAubin alexAubin added this to In progress in 11.1 Aug 6, 2022
@alexAubin alexAubin changed the base branch from dev to 11.1 September 4, 2022 17:42
@alexAubin alexAubin merged commit d01885e into 11.1 Sep 4, 2022
@alexAubin alexAubin deleted the enh-global-settings-configpanel branch September 4, 2022 17:42
@alexAubin alexAubin mentioned this pull request Sep 4, 2022
Merged
13 tasks
@alexAubin alexAubin moved this from In progress to Done in 11.1 Oct 4, 2022
@alexAubin alexAubin restored the enh-global-settings-configpanel branch October 6, 2022 17:06
@alexAubin alexAubin deleted the enh-global-settings-configpanel branch October 6, 2022 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexAubin alexAubin alexAubin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
No open projects
11.1
Done
Milestone
No milestone
2 participants
@Tagadda @alexAubin