11.1 #1502
Merged
11.1 #1502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cripts except remove
…disk/ram, ... + drop disk/ram as resource, have them directly in 'integration'
…ith possible rollback
…as-virtual-global-setting
…l-global-setting Implement a new 'virtual global setting' to change root password from…
Merge firstname and lastname
Improve most used password check list
zamentur
reviewed
Oct 16, 2022
| """ | ||
| Convert bytes or bits into human readable format with binary prefix | ||
| """ | ||
| symbols = ("K", "M", "G", "T", "P", "E", "Z", "Y") |
There was a problem hiding this comment.
The previous binary_to_human was supporting GiB notation. What should we do about that ?
There was a problem hiding this comment.
Is that really important x_x
There was a problem hiding this comment.
I guess I dropped it because I unified it with a _convertSize function from user.py which was basically doing the same thing, but without the GiB notation ...
|
Are you sure you copied the proper config_domain.toml and config_global.toml in your dev env ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently: