Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Await session closing #11

Merged
merged 2 commits into from
Feb 12, 2018
Merged

Await session closing #11

merged 2 commits into from
Feb 12, 2018

Conversation

id13
Copy link
Contributor

@id13 id13 commented Feb 12, 2018

In order to comply with aiohttp >= 3.0 warning pytest_sanic/utils.py:227: RuntimeWarning: coroutine 'ClientSession.close' was never awaited

I checked this patch for aiohttp >= 3.0 and 2.0 <= aiohttp < 3.0

In order to comply with aiohttp >= 3.0 warning `pytest_sanic/utils.py:227: RuntimeWarning: coroutine 'ClientSession.close' was never awaited`
@coveralls
Copy link

coveralls commented Feb 12, 2018

Coverage Status

Coverage increased (+2.7%) to 97.717% when pulling ede4682 on id13:master into f78925f on yunstanford:master.

@yunstanford
Copy link
Owner

@id13 Thanks for the PR. I think it's ok to upgrade to aiohttp>=3.0. Can you also add the version specifier in setup.py ? https://github.com/yunstanford/pytest-sanic/blob/master/setup.py#L12

Thanks a lot.

@id13
Copy link
Contributor Author

id13 commented Feb 12, 2018

@yunstanford done

@yunstanford yunstanford merged commit 76c2954 into yunstanford:master Feb 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants